New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xpra: fix #85694 #87985
xpra: fix #85694 #87985
Conversation
Previously we had to use:
I'm assuming after this PR, disabling fake-xinerama is no longer supposed to be necessary? I tried to test this but getting the following error: Steps:
clientside:
serverside
|
Yes it is.
Cannot reproduce. On my machine (under GNOME3) both xterm and konsole go through without any fatal errors. Looks like this is another bug entirely that you hit because this one is squashed. Without this patch, the client side crashes like has been reported previously:
|
@mjlbach Just reproduced on a KDE virtual machine. That seems to be KDE specific for some reason. Can you open an issue? |
Yes, I'll do that right now. Just to clarify, even with this patch, we should still use |
My bad. The |
I'm having a hard time reproducing the failure, I just reinstalled this PR to run some debugging and it seems to work. I'm curious what you did in the VM, because i can't figure out what is different. The one thing I noticed (which I can open a separate issue for) is that xpra seems to not shut down cleanly, requiring killing the process to get it to start on the same DISPLAY.
The following works on my computer now:
So this PR LGTM? Thanks for fixing this, this has been one of those packages that I've always missed working on NixOS. |
My VM is a declaratively built QEMU VM. It's here. (You probably want to remove the Lourkeur™ Custom™ Ergonomic Keyboard Layout™.) It has access to the host's Nix store, that's how I got rebuilt xpra's on it. |
@offlinehacker please lmk what I have left to do to get this merged |
It looks good, I just waited some time to see if anyone will comment anything, but I think we can merge it 🙂 |
Motivation for this change
Fix #85694
Things done
Hard-code the default libfakeXinerama location instead of relying on the automatic detection dance that upstream does.
I tried to make the dance succeed but couldn't do it. It would require at least bringing in binutils so ctypes.util can call ld and adding a SONAME to libfakeXinerama, but in fine it would still be quite fragile.
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)