Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fakeXinerama: clean up minor issues #87983

Merged
merged 2 commits into from Aug 22, 2020

Conversation

bbjubjub2494
Copy link
Member

Motivation for this change

Originally I was putting fire on a xpra bug, but now it seems that this isn't strictly necessary. Still, applying some hygiene on this package now could help maintainers in the future.

Things done
  • Fix dangling symlinks
  • don't set phases on derivation because that's discouraged

TODO: e-mail maintainer Thomas Strobel

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bbjubjub2494 bbjubjub2494 marked this pull request as ready for review May 20, 2020 08:51
@Lassulus Lassulus merged commit 344787c into NixOS:master Aug 22, 2020
@bbjubjub2494 bbjubjub2494 deleted the cleanup_libfakeXinerama branch March 29, 2022 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants