Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

procs: 0.8.11 -> 0.8.13 #72348

Merged
merged 1 commit into from Oct 31, 2019
Merged

procs: 0.8.11 -> 0.8.13 #72348

merged 1 commit into from Oct 31, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Oct 31, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @dalance

@ofborg ofborg bot requested a review from dalance October 31, 2019 03:29
dalance
dalance approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@dalance dalance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

jonringer
jonringer approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable seems to work
leaf packages

[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/72348
1 package were build:
procs

@jonringer jonringer merged commit b861611 into NixOS:master Oct 31, 2019
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 16, 2019

@dalance @marsam just a heads-up that procs fails to build on Hydra for amd64 linux and darwin because of too many file descriptors used during check phase.
See https://hydra.nixos.org/build/106523887 for example.

rust-lang/rust#7772 might be related.
Setting RUST_RT_TEST_THREADS env var to a lower number should solve it but I haven't tried to reproduce and test locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalance dalance dalance approved these changes

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marsam @c0bw3b @dalance @jonringer