Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

polkit: Fix unstable patch URL #72301

Merged
merged 1 commit into from Oct 30, 2019
Merged

polkit: Fix unstable patch URL #72301

merged 1 commit into from Oct 30, 2019

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Oct 30, 2019

Extracted from #72057 due to Linux500+ mass rebuild.

Motivation for this change

Unmerged upstream merge requests can change when iterated on!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

no maintainers in file

@nh2
polkit: Fix unstable patch URL.
0e10ad9 
Unmerged upstream merge requests can change when iterated on!
@nh2 nh2 requested a review from worldofpeace October 30, 2019 13:57
@nh2 nh2 mentioned this pull request Oct 30, 2019
Merged
10 tasks
@veprbl veprbl added this to Ready in Staging Oct 30, 2019
@nh2 nh2 merged commit 6b7f343 into NixOS:staging Oct 30, 2019
@worldofpeace worldofpeace moved this from Ready to Merged in Staging Oct 30, 2019
@veprbl
Copy link
Member

veprbl commented Oct 30, 2019

I just realized this should not have been a rebuild. Can just set name = "11.patch" in fetchurl instead.

@nh2 nh2 mentioned this pull request Nov 3, 2019
Open
60 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nh2 @veprbl