Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cheat: 2.5.1 -> 3.0.3 #72299

Merged
merged 2 commits into from Oct 30, 2019
Merged

cheat: 2.5.1 -> 3.0.3 #72299

merged 2 commits into from Oct 30, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Oct 30, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from kalbasit October 30, 2019 13:58
@prusnak
Copy link
Member

prusnak commented Oct 30, 2019 •
edited

  • homepage should read "https://github.com/cheat/cheat"
  • description should not contain the name of the package, suggestion: "Create and view interactive cheatsheets on the command-line"

@Mic92 Mic92 merged commit 970a22c into NixOS:master Oct 30, 2019
@Mic92 Mic92 deleted the cheat branch October 30, 2019 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @prusnak