Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dotnet.sdk: 2.2.6 -> 3.0.100 #72300

Closed
wants to merge 2 commits into from
Closed

dotnet.sdk: 2.2.6 -> 3.0.100 #72300

wants to merge 2 commits into from

Conversation

ezemtsov
Copy link
Contributor

@ezemtsov ezemtsov commented Oct 30, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from kuznero October 30, 2019 14:09
prusnak
prusnak reviewed Oct 30, 2019
View reviewed changes
pkgs/development/compilers/dotnet/sdk/default.nix Outdated
version = "2.2.401";
netCoreVersion = "2.2.6";
version = "3.0.100";
netCoreVersion = "3.0.100";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

netCoreVersion should be 3.0.0

@prusnak
Copy link
Member

prusnak commented Oct 30, 2019 •
edited

Please also change the homepage to:

homepage = "https://dotnet.microsoft.com/";

@prusnak
Copy link
Member

prusnak commented Oct 30, 2019

@GrahamcOfBorg build dotnet-sdk

@jonringer
Copy link
Contributor

jonringer commented Oct 30, 2019 •
edited

duplicate of #69392

holding off on 3.0.100 due to odd runtime behavior

@baracoder baracoder mentioned this pull request Nov 12, 2019
Merged
10 tasks
@kuznero
Copy link
Member

kuznero commented Nov 13, 2019

Looks good to me. @jonringer what do you mean by odd behavior?

@kuznero kuznero mentioned this pull request Nov 13, 2019
Closed
@jonringer
Copy link
Contributor

Currently the dotnet executable will check to see if it has a given dotnet runtime, if it doesn't, then it tries to download it into the nix store causing issues when you do a dotnet restore

@jonringer
Copy link
Contributor

Thank you for submitting a PR, however, this is surpassed by #73262 which also enabled combining many sdk's into a single environment.

@jonringer jonringer closed this Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak left review comments

@kuznero kuznero kuznero approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ezemtsov @prusnak @jonringer @kuznero