Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

twitter-color-emoji: use noto-fonts-emoji’s src #72313

Merged
merged 2 commits into from Oct 31, 2019
Merged

twitter-color-emoji: use noto-fonts-emoji’s src #72313

merged 2 commits into from Oct 31, 2019

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Oct 30, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace
Copy link
Contributor

EmojiOne did fail for me

Traceback (most recent call last):
  File "/nix/store/6yl3kmgd09r33xs5gc58v9ihymsw1pkl-scfbuild-1.0.3/bin/.scfbuild-wrapped", line 18, in <module>
    sys.exit(main())
  File "/nix/store/6yl3kmgd09r33xs5gc58v9ihymsw1pkl-scfbuild-1.0.3/lib/python3.7/site-packages/scfbuild/main.py", line 124, in main
Traceback (most recent call last):
  File "/nix/store/6yl3kmgd09r33xs5gc58v9ihymsw1pkl-scfbuild-1.0.3/bin/.scfbuild-wrapped", line 18, in <module>
    return builder.run()
  File "/nix/store/6yl3kmgd09r33xs5gc58v9ihymsw1pkl-scfbuild-1.0.3/lib/python3.7/site-packages/scfbuild/builder.py", line 58, in run
    sys.exit(main())
  File "/nix/store/6yl3kmgd09r33xs5gc58v9ihymsw1pkl-scfbuild-1.0.3/lib/python3.7/site-packages/scfbuild/main.py", line 124, in main
    fforge.add_glyphs(ff_font, svg_filepaths, self.conf)
  File "/nix/store/6yl3kmgd09r33xs5gc58v9ihymsw1pkl-scfbuild-1.0.3/lib/python3.7/site-packages/scfbuild/fforge.py", line 87, in add_glyphs
    u_str = ''.join(map(unichr, u_ids))
NameError: name 'unichr' is not defined
    return builder.run()
  File "/nix/store/6yl3kmgd09r33xs5gc58v9ihymsw1pkl-scfbuild-1.0.3/lib/python3.7/site-packages/scfbuild/builder.py", line 58, in run
    fforge.add_glyphs(ff_font, svg_filepaths, self.conf)
  File "/nix/store/6yl3kmgd09r33xs5gc58v9ihymsw1pkl-scfbuild-1.0.3/lib/python3.7/site-packages/scfbuild/fforge.py", line 87, in add_glyphs
    u_str = ''.join(map(unichr, u_ids))
NameError: name 'unichr' is not defined
make: *** [Makefile:93: build/EmojiOneColor-SVGinOT-OSX.ttf] Error 1
make: *** Waiting for unfinished jobs....

@jtojnar jtojnar force-pushed the fixup-twitter-font branch 2 times, most recently from 757b719 to b6744f8 Compare October 30, 2019 18:41
@ofborg ofborg bot requested a review from abbradar October 30, 2019 18:55
@jtojnar
Copy link
Contributor Author

jtojnar commented Oct 30, 2019

@GrahamcOfBorg build twemoji-color-font emojione

@jtojnar
Copy link
Contributor Author

jtojnar commented Oct 31, 2019 •
edited

The patch was not being applied. Aargh, foiled by phases again.

@jtojnar
scfbuild: switch to Python 3
fc1a728 
Needed to drop phases @#$% to be able to use this at all.

Fixes emojione and twemoji-color-font
@jtojnar
Copy link
Contributor Author

jtojnar commented Oct 31, 2019

@GrahamcOfBorg build twemoji-color-font emojione

worldofpeace
worldofpeace approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could build emojione and twitter-color-emoji.
Not sure about the darwin failures, but this takes too long to test for me to investigate it further.

@worldofpeace worldofpeace merged commit c613d70 into NixOS:master Oct 31, 2019
@worldofpeace worldofpeace deleted the fixup-twitter-font branch October 31, 2019 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package 'fonttools' requires a different Python: 2.7.17 not in '>=3.6'
3 participants
@jtojnar @worldofpeace @FRidh