Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transifex-client: Fix build #72408

Merged
merged 1 commit into from Nov 9, 2019
Merged

transifex-client: Fix build #72408

merged 1 commit into from Nov 9, 2019

Conversation

etu
Copy link
Contributor

@etu etu commented Nov 1, 2019 •
edited

Motivation for this change

We have updated python-slugify to 4.0.0 (or newer) which broke the
build. This has happened several times before without actually
breaking the software.

So yeah, lets just accept newer versions and fix it if it breaks for
some other reason in the future.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@etu
transifex-client: Fix build
ee16c54 
We have updated python-slugify to 4.0.0 (or newer) which broke the
build. This has happened several times before without actually
breaking the software.

So yeah, lets just accept newer versions and fix it if it breaks for
some other reason in the future.
@etu etu added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 1, 2019
@etu etu removed the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 1, 2019
@c0bw3b c0bw3b merged commit f80a56f into NixOS:master Nov 9, 2019
@etu etu deleted the transifex-fix-build branch November 9, 2019 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam approved these changes

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@etu @marsam @c0bw3b