Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/geoclue: minor cleanups #72281

Merged
merged 2 commits into from Oct 31, 2019
Merged

nixos/geoclue: minor cleanups #72281

merged 2 commits into from Oct 31, 2019

Conversation

peterhoeg
Copy link
Member

  • spawn the geoclue-agent directly instead of running it via bash
  • document why we cannot use DynamicUser = true
  • have systemd create the home directory instead of using an explicit
    tmpfiles.d fragment
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peterhoeg
nixos/geoclue: minor cleanups
d7ebe00 
 - spawn the geoclue-agent directly instead of running it via bash
 - document why we cannot use DynamicUser = true
 - have systemd create the home directory instead of using an explicit
   tmpfiles.d fragment
worldofpeace
worldofpeace approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing in a vm that the demo agent would start and I could use a geoclue using app gnome-weather.
I should probably add myself to meta.maintainers for this module.

@worldofpeace worldofpeace merged commit d5c639c into NixOS:master Oct 31, 2019
@peterhoeg peterhoeg deleted the f/geoclue branch November 3, 2019 12:41
@maisiliym
Copy link

For the record, the ExecStart attribute still uses the system shell (bash).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterhoeg @maisiliym @worldofpeace