Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rPackages.glmnet: Add missing dependency #72389

Merged
merged 1 commit into from
Nov 11, 2019
Merged

rPackages.glmnet: Add missing dependency #72389

merged 1 commit into from
Nov 11, 2019
+1 −0

Conversation

nkpart
Copy link
Contributor

@nkpart nkpart commented Oct 31, 2019

Motivation for this change

Fixes the error:
ld: library not found for -liconv

I've followed the convention of other packages relying on iconv.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@nkpart
rPackages.glmnet: Add missing dependency
4d54c9e 
Fixes the error:
    ld: library not found for -liconv
@nkpart nkpart requested a review from peti as a code owner October 31, 2019 22:16
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 31, 2019
@nkpart
Copy link
Contributor Author

nkpart commented Nov 5, 2019 •
edited
Loading

I've done a bit more playing with the rPackages on Darwin, and I've realised this fix is only necessary on that platform. rPackages.glmnet works fine on linux using Nixpkgs master.

I can't see any "prior art" which adds iconv for Darwin only, so not sure if that's the right thing to do.

This kind of fix is also needed for rPackages.lars as well, and so there might be a bunch more.

@peti peti merged commit 1a2415e into NixOS:master Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nkpart @peti