Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mame: init at 0.215 #72319

Merged
merged 3 commits into from Nov 3, 2019
Merged

mame: init at 0.215 #72319

merged 3 commits into from Nov 3, 2019

Conversation

ghost
Copy link

@ghost ghost commented Oct 30, 2019

Motivation for this change

MAME is a multi-purpose emulation framework.

Closes #36206

MAME’s purpose is to preserve decades of software history. As electronic technology continues to rush forward, MAME prevents this important "vintage" software from being lost and forgotten. This is achieved by documenting the hardware and how it functions. The source code to MAME serves as this documentation. The fact that the software is usable serves primarily to validate the accuracy of the documentation (how else can you prove that you have recreated the hardware faithfully?). Over time, MAME (originally stood for Multiple Arcade Machine Emulator) absorbed the sister-project MESS (Multi Emulator Super System), so MAME now documents a wide variety of (mostly vintage) computers, video game consoles and calculators, in addition to the arcade video games that were its initial focus.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ghost
Copy link
Author

ghost commented Nov 2, 2019

@GrahamcOfBorg build mame

pkgs/misc/emulators/mame/default.nix Outdated Show resolved Hide resolved
pkgs/misc/emulators/mame/default.nix Outdated Show resolved Hide resolved
gnidorah added 3 commits November 3, 2019 20:02
MAME and MESS are now combined as one distribution as of the 0.162 release and offered as a MAME binary (MESS is included in the build).
There are no longer separate programs called SDLMAME or SDLMESS. Instead, the SDL capability is included in MAME and MESS, and the makefile will auto-detect if you are on a non-Windows system and run accordingly.
@ghost
Copy link
Author

ghost commented Nov 3, 2019

@worldofpeace Done, thank you!

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks ✨

@worldofpeace worldofpeace merged commit 7c4f09f into NixOS:master Nov 3, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 3, 2019
mame: init at 0.215
(cherry picked from commit 7c4f09f)
@ghost
Copy link
Author

ghost commented Nov 4, 2019

@worldofpeace Thank you!

@ghost ghost deleted the mame branch November 4, 2019 05:18
@ghost ghost mentioned this pull request Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant