Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

welle-io: 1.0 -> 2.0 #72355

Merged
merged 1 commit into from Oct 31, 2019
Merged

welle-io: 1.0 -> 2.0 #72355

merged 1 commit into from Oct 31, 2019

Conversation

markuskowa
Copy link
Member

Motivation for this change

New major version.

Things done
  • Update version
  • Fix Qt mkDerivation
  • Tested with RTL-SDR device
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ck3d

@ofborg ofborg bot requested a review from ck3d October 31, 2019 08:42
ck3d
ck3d approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@ck3d ck3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating

@mmahut mmahut merged commit 1d9e1d4 into NixOS:master Oct 31, 2019
@markuskowa markuskowa deleted the upd-welle branch October 31, 2019 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ck3d ck3d ck3d approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markuskowa @ck3d @mmahut