Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: be85360e08ef
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 20d698862824
Choose a head ref
  • 4 commits
  • 3 files changed
  • 3 contributors

Commits on Oct 30, 2019

  1. polkit: Fix unstable patch URL.

    Unmerged upstream merge requests can change when iterated on!
    nh2 committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    0e10ad9 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #72301 from nh2/polkit-stable-patch-url

    polkit: Fix unstable patch URL
    nh2 committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    6b7f343 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2019

  1. itstool: 2.0.2 -> 2.0.6

    To get python3 support.  #63174 flipped itstool to python3, but itstool
    doesn't support python3 until 2.0.3 (and perhaps does not support it
    well until 2.0.5).
    
    Pressing forward instead of rolling back at worldofpeace's suggestion,
    who mentions that other distros seem to be able to ship recent versions
    of itstool.
    
    Tensions in this space seem two-fold.  One set centers around libxml2
    being a low-level C library with sharp edges, manual memory management,
    and performance concerns; the python libxml2 wrapper being quite thin
    (the most dubious character in this drama); and python's sentiment that
    it ought to be quite hard to crash the interpreter casually.  This comes
    to a head in https://gitlab.gnome.org/GNOME/libxml2/issues/12 , where a
    use-after-free problem in idiomatic-looking python code is declared
    working-as-designed.
    
    The other set is around python3 being more UTF-8-aware than libxml2's
    python wrapper, such as https://bugzilla.gnome.org/show_bug.cgi?id=789714
    and https://src.fedoraproject.org/rpms/libxml2/blob/master/f/libxml2-2.9.8-python3-unicode-errors.patch
    
    itstool is caught in this crossfire merely for being a widely-used
    python program that uses XML.
    chkno committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    0c999c7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    20d6988 View commit details
    Browse the repository at this point in the history