Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins.antonys-macro-repeater: init at 2017-09-10 #72317

Merged
merged 2 commits into from Oct 31, 2019
Merged

vimPlugins.antonys-macro-repeater: init at 2017-09-10 #72317

merged 2 commits into from Oct 31, 2019

Conversation

justinlovinger
Copy link
Contributor

@justinlovinger justinlovinger commented Oct 30, 2019 •
edited by jonringer

Motivation for this change

Add antonys-macro-repeater vim plugin

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested vim plugin
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ teto

jonringer
jonringer approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
commits LGTM (followed guidelines)

[9 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/72317
4 package were build:
vimPlugins.antonys-macro-repeater vimPlugins.coc-git vimPlugins.coc-java vimPlugins.vim-ledger

@jonringer jonringer merged commit 274bf0a into NixOS:master Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@justinlovinger @jonringer