Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onnxruntime: 0.5.0 -> 1.0.0 #72315

Merged
merged 1 commit into from Nov 5, 2019
Merged

onnxruntime: 0.5.0 -> 1.0.0 #72315

merged 1 commit into from Nov 5, 2019

Conversation

jonringer
Copy link
Contributor

Motivation for this change

just had a release ~12 hrs ago

https://github.com/microsoft/onnxruntime/releases

updated some of the metadata, and enabled parallel-building

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

[11:28:31] jon@jon-workstation ~/projects/nixpkgs (bump-onnxruntime)
$ nix path-info -Sh ./result
/nix/store/nh33kjq4nlx9zi6rv6yk5h3px766w5pw-onnxruntime-1.0.0     42.1M
$ nix path-info -Sh ./result-dev
/nix/store/p4dj9jdfzyi2rj0d0zfh5c9ql08vfwj3-onnxruntime-1.0.0-dev         42.4M

@jonringer jonringer mentioned this pull request Oct 30, 2019
Closed
@jonringer
Copy link
Contributor Author

@marsam do you mind taking a look?

@jonringer jonringer merged commit 65db5ce into NixOS:master Nov 5, 2019
@jonringer jonringer deleted the bump-onnxruntime branch November 5, 2019 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @marsam