Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/fontconfig-ultimate: remove #72369

Merged
merged 3 commits into from
Nov 7, 2019
Merged

nixos/fontconfig-ultimate: remove #72369

merged 3 commits into from
Nov 7, 2019
+15 −175

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

See discussion at #67529. This was long overdue.

I also removed fonts.enableCoreFonts as it also looked due for removal.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@worldofpeace worldofpeace requested review from jtojnar and volth October 31, 2019 14:35
vcunat
vcunat approved these changes Nov 2, 2019
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. (I didn't really check for typos, etc.)

@worldofpeace
Copy link
Contributor Author

@GrahamcOfBorg eval

@grahamc
Copy link
Member

grahamc commented Nov 6, 2019

This PR's eval came in at a wonderful time where github had a bug and has since periodically exposed other bugs in github. If you wouldn't mind, would you rebase this PR again, which would work around the bug in ofborg for now?

@worldofpeace
nixos/corefonts: remove
3485204 
4 years ago in 7edb27b the option was made
hidden. We should just remove the module and use mkRemovedOptionModule.
@worldofpeace
Copy link
Contributor Author

This PR's eval came in at a wonderful time where github had a bug and has since periodically exposed other bugs in github. If you wouldn't mind, would you rebase this PR again, which would work around the bug in ofborg for now?

Done, I was considering if that was going to be my only option anyways 😄

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 6, 2019
@worldofpeace
nixos/fontconfig-ultimate: remove
070fbc3 
This module has been obsolete for several years now.
@worldofpeace
fontconfig-ultimate: remove
7a551b3
@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 6, 2019
@worldofpeace worldofpeace merged commit 7c71670 into NixOS:master Nov 7, 2019
@worldofpeace worldofpeace deleted the corefonts-drop branch November 7, 2019 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar

@vcunat vcunat

@jonringer jonringer

@infinisil infinisil

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: clean-up 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
Picking up garbage
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@worldofpeace @grahamc @jtojnar @vcunat @jonringer