Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uw-ttyp0: init at 1.3 #72368

Merged
merged 1 commit into from
Dec 8, 2019
Merged

uw-ttyp0: init at 1.3 #72368

merged 1 commit into from
Dec 8, 2019
+93 −0

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Oct 31, 2019

Motivation for this change

A nice bitmap font with good unicode support.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested in xterm and linux virtual console
  • Tested execution of all binary files (none)
  • Determined the impact on package closure size (n/a)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 31, 2019
vyp
vyp suggested changes Oct 31, 2019
View reviewed changes
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Nov 8, 2019

@GrahamcOfBorg build uw-ttyp0

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Nov 8, 2019

Looks like the build is not deterministic :(

@rnhmjoj rnhmjoj force-pushed the ttyp0 branch 2 times, most recently from 06cdfb6 to 7047ec2 Compare November 28, 2019 18:31
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Nov 28, 2019

@GrahamcOfBorg build uw-ttyp0

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Nov 28, 2019

Seems good now. I also contacted the author about this and a fix will be made for the next release.

This was referenced Dec 6, 2019
Closed
Closed
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/91

Lassulus
Lassulus approved these changes Dec 8, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lassulus Lassulus merged commit a8db8dd into NixOS:master Dec 8, 2019
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Dec 8, 2019

Thank you.

@rnhmjoj rnhmjoj deleted the ttyp0 branch January 8, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyp vyp

@Lassulus Lassulus

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rnhmjoj @nixos-discourse @Lassulus @vyp