Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uw-ttyp0: init at 1.3 #72368

Merged
merged 1 commit into from Dec 8, 2019
Merged

uw-ttyp0: init at 1.3 #72368

merged 1 commit into from Dec 8, 2019

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Oct 31, 2019

Motivation for this change

A nice bitmap font with good unicode support.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested in xterm and linux virtual console
  • Tested execution of all binary files (none)
  • Determined the impact on package closure size (n/a)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pkgs/data/fonts/uw-ttyp0/default.nix Outdated Show resolved Hide resolved
pkgs/data/fonts/uw-ttyp0/default.nix Outdated Show resolved Hide resolved
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Nov 8, 2019

@GrahamcOfBorg build uw-ttyp0

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Nov 8, 2019

Looks like the build is not deterministic :(

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Nov 28, 2019

@GrahamcOfBorg build uw-ttyp0

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Nov 28, 2019

Seems good now. I also contacted the author about this and a fix will be made for the next release.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/91

Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lassulus Lassulus merged commit a8db8dd into NixOS:master Dec 8, 2019
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Dec 8, 2019

Thank you.

@rnhmjoj rnhmjoj deleted the ttyp0 branch January 8, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants