Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k9s: 0.8.4 -> 0.9.3 #72289

Merged
merged 1 commit into from Dec 8, 2019
Merged

k9s: 0.8.4 -> 0.9.3 #72289

merged 1 commit into from Dec 8, 2019

Conversation

jlesquembre
Copy link
Member

Motivation for this change

Update and add missed build flags

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Gonzih

@jlesquembre
k9s: 0.8.4 -> 0.9.3
6d08d0e 
Also add missed build flags
@ofborg ofborg bot requested review from Gonzih and kalbasit October 30, 2019 10:56
Gonzih
Gonzih approved these changes Oct 30, 2019
View reviewed changes
Copy link
Contributor

@Gonzih Gonzih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested via nix-review

Thanks a lot!

@jlesquembre
Copy link
Member Author

ping @kalbasit I think this PR is blocked waiting for your review, could you take a look? Thanks in advance.
I've been using k9s with my update for almost a month without problems.

@Gonzih Gonzih mentioned this pull request Dec 6, 2019
Merged
10 tasks
Lassulus
Lassulus approved these changes Dec 8, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review

@Lassulus Lassulus merged commit 848e0d3 into NixOS:master Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gonzih Gonzih Gonzih approved these changes

@Lassulus Lassulus Lassulus approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jlesquembre @Gonzih @Lassulus