Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rPackages.ModelMetrics: fix darwin build #72338

Merged
merged 1 commit into from Oct 31, 2019
Merged

rPackages.ModelMetrics: fix darwin build #72338

merged 1 commit into from Oct 31, 2019

Conversation

nkpart
Copy link
Contributor

@nkpart nkpart commented Oct 31, 2019

Motivation for this change

Fixes build of ModelMetrics on Darwin, openmp needs to be explicitly provided.

This allows many downstream packages to build as well (such as caret).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@nkpart
rPackages.ModelMetrics: fix darwin build
f21ac0e 
This fixes the error:

	auc_.cpp:2:10: fatal error: 'omp.h' file not found
	#include <omp.h>
@nkpart nkpart requested a review from peti as a code owner October 31, 2019 00:12
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Oct 31, 2019
@peti peti merged commit 6bd0704 into NixOS:master Oct 31, 2019
@nkpart nkpart deleted the nkpart/fix-rPackages-ModelMetrics branch October 31, 2019 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nkpart @peti @Janik-Haag