Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cawbird: 1.0.2 -> 1.0.3.1 #72339

Merged
merged 1 commit into from Oct 31, 2019
Merged

cawbird: 1.0.2 -> 1.0.3.1 #72339

merged 1 commit into from Oct 31, 2019

Conversation

schmittlauch
Copy link
Member

Motivation for this change

simple version bump of the cawbird client. Has been done as part of some further backports for release-19.09, see the according PR for that.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@schmittlauch
Copy link
Member Author

@GrahamcOfBorg build cawbird

@schmittlauch schmittlauch mentioned this pull request Oct 31, 2019
Closed
10 tasks
@ofborg ofborg bot requested a review from jonafato October 31, 2019 00:51
jonringer
jonringer approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
commits LGTM
executable gui launches fine
leaf package

[3 built, 5 copied (26.5 MiB), 5.8 MiB DL]
https://github.com/NixOS/nixpkgs/pull/72339
1 package were build:
cawbird

@jonringer
Copy link
Contributor

@GrahamcOfBorg build cawbird

jonringer
jonringer approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
commits LGTM
gui launches

https://github.com/NixOS/nixpkgs/pull/72339
1 package were build:
cawbird

@jonringer
Copy link
Contributor

arch failure related to ghostscript

@jonringer jonringer merged commit 01c7499 into NixOS:master Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonafato jonafato jonafato approved these changes

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@schmittlauch @jonringer @jonafato