Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonpackages.scikitimage: add missing dependency #72378

Merged
merged 1 commit into from
Nov 1, 2019
Merged

pythonpackages.scikitimage: add missing dependency #72378

merged 1 commit into from
Nov 1, 2019
+3 −2

Conversation

tbenst
Copy link
Contributor

@tbenst tbenst commented Oct 31, 2019

Motivation for this change

imageio is a required package for scikit-image according to https://github.com/scikit-image/scikit-image/blob/master/requirements/default.txt but is missing from derivation. This causes a failed build.

Things done
  • Tested using sandboxing
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

Sorry, something went wrong.

@tbenst
pythonpackages.scikitimage: add missing dependency

Verified

This commit was signed with the committer’s verified signature. The key has expired.
marsam Mario Rodas
GPG key ID: 4C4BEFD7B18DC5E8
Expired
Verified
Learn about vigilant mode
a59682f
@tbenst tbenst mentioned this pull request Oct 31, 2019
Merged
10 tasks
jonringer
jonringer approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS (failures are broken on master)
diff LGTM
does fix build

[13 built (3 failed), 439 copied (3412.2 MiB), 1316.4 MiB DL]
error: build of '/nix/store/ps9vnxga5vxbg1c3gysqkj6nn6w59xdc-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/72378
1 package are marked as broken and were skipped:
python37Packages.imgaug

4 package failed to build:
python37Packages.rl-coach python37Packages.slicedimage python37Packages.starfish python37Packages.sunpy

8 package were build:
python37Packages.aplpy python37Packages.caffe python37Packages.dask-image python37Packages.datashader python37Packages.glymur python37Packages.image-match python37Packages.pims python37Packages.scikitimage

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python37Packages.aplpy python37Packages.caffe python37Packages.dask-image python37Packages.datashader python37Packages.glymur python37Packages.image-match python37Packages.pims python37Packages.scikitimage

@FRidh FRidh merged commit 2958eb6 into NixOS:master Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer

@FRidh FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tbenst @jonringer @FRidh