Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enlightenment.efl: 1.22.5 -> 1.23.1 #72027

Merged
merged 5 commits into from Oct 31, 2019
Merged

enlightenment.efl: 1.22.5 -> 1.23.1 #72027

merged 5 commits into from Oct 31, 2019

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Oct 26, 2019 •
edited

Motivation for this change
  • enlightenment.efl: 1.22.5 -> 1.23.1
  • pythonPackage.python-efl: 1.22.0 -> 1.23.0
  • enlightenment.{enlightenment,ephoto,rage,terminology}: use default pkgconfig
  • enlightenment.{econnman,efl,terminology}, pythonPackages.python-efl: add romildo as maintainer
  • Edited: enlightenment.efl: remove dependence on xineLib

Tested on a VM.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @matejc @ftrvxmtrx

@romildo
enlightenment.efl: 1.22.5 -> 1.23.1
dfb2638 
- Update to version 1.23.1
- Switch to meson build system
- Add new dependencies: avahi, ibus, check
@romildo
pythonPackage.python-efl: 1.22.0 -> 1.23.0
51cf860
@romildo
enlightenment.{enlightenment,ephoto,rage,terminology}: use default pk…
ac93f9b 
…gconfig

With efl-1.23.1 built with meson the native pkgconfig is not needed
anymore, and building fails with it.
@romildo
enlightenment.{econnman,efl,terminology}, pythonPackages.python-efl: …
b63e0a5 
…add romildo as maintainer
@romildo
enlightenment.efl: remove dependence on xineLib
f38c52a 
EFL supports four video back-ends: gstreamer, gstreamer1, libvlc, and
xine. After asking in the IRC channel, the author (raster) recommended
enabling gstreamer1 and disabling the others.
@romildo
Copy link
Contributor Author

romildo commented Oct 28, 2019

@GrahamcOfBorg build enlightenment.efl python2Packages.pythonefl enlightenment.econnman enlightenment.ephoto enlightenment.rage enlightenment.terminology enlightenment.enlightenment

c0bw3b
c0bw3b approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review pr 72027 1

9 package were build:
  • enlightenment.econnman
  • enlightenment.efl
  • enlightenment.enlightenment
  • enlightenment.ephoto
  • enlightenment.rage
  • enlightenment.terminology
  • python27Packages.pythonefl
  • python37Packages.pythonefl
  • python38Packages.pythonefl

@romildo romildo merged commit 9e37a76 into NixOS:master Oct 31, 2019
@romildo romildo deleted the upd.efl branch October 31, 2019 14:01
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 1, 2019
@romildo @dtzWill
Merge pull request NixOS#72027 from romildo/upd.efl (+sync)
54e28f0 
enlightenment.efl: 1.22.5 -> 1.23.1

(cherry picked from commit 9e37a76)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romildo @c0bw3b