Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tealdeer: 1.1.0 -> 1.2.0 #72402

Merged
merged 1 commit into from Nov 1, 2019
Merged

tealdeer: 1.1.0 -> 1.2.0 #72402

merged 1 commit into from Nov 1, 2019

Conversation

jwijenbergh
Copy link
Contributor

@jwijenbergh jwijenbergh commented Nov 1, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @davidak

@ofborg ofborg bot requested a review from davidak November 1, 2019 03:15
davidak
davidak approved these changes Nov 1, 2019
View reviewed changes
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jwijenbergh thanks for your contribution!

Reviewed points
  • package name fits guidelines
  • package version fits guidelines
  • package build on x86_64-linux
  • executables tested on x86_64-linux
  • all depending packages build

@dywedir
Copy link
Member

dywedir commented Nov 1, 2019 •
edited

@GrahamcOfBorg build tealdeer

@dywedir dywedir closed this Nov 1, 2019
@dywedir dywedir reopened this Nov 1, 2019
@ofborg ofborg bot requested a review from davidak November 1, 2019 08:12
@dywedir dywedir merged commit f46d934 into NixOS:master Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidak davidak Awaiting requested review from davidak

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jwijenbergh @dywedir @davidak