Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpython: fix build #72371

Merged
merged 1 commit into from
Oct 31, 2019
Merged

bpython: fix build #72371

merged 1 commit into from
Oct 31, 2019
+1 −1

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Oct 31, 2019

aeb63f4 bumped bpython to 0.18, but it
failed to build afterwards, due to the .desktop file being renamed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • [ x Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@flokli
bpython: fix build
64eab81 
aeb63f4 bumped bpython to 0.18, but it
failed to build afterwards, due to the .desktop file being renamed.
@flokli flokli requested review from FRidh and dotlambda October 31, 2019 15:41
@flokli flokli requested a review from jonringer as a code owner October 31, 2019 15:41
@flokli flokli mentioned this pull request Oct 31, 2019
Merged
10 tasks
@ofborg ofborg bot added 6.topic: python 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 31, 2019
@FRidh
Copy link
Member

FRidh commented Oct 31, 2019

@GrahamcOfBorg build python3.pkgs.bpython

jonringer
jonringer approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
commits LGTM
executables seem to work

[4 built, 109 copied (148.6 MiB), 27.6 MiB DL]
https://github.com/NixOS/nixpkgs/pull/72371
3 package were build:
python27Packages.bpython python37Packages.bpython python38Packages.bpython

@jonringer jonringer merged commit e390771 into NixOS:master Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer

@FRidh FRidh

@dotlambda dotlambda

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flokli @FRidh @jonringer