New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
css/css-animations/keyframes-remove-documentElement-crash.html causes a harness failure #20020
Comments
Interestingly, it seems to work ok under I think it's worth taking a quick look at it from the infra side, to understand what the difference is there. In terms of whether the test 'belongs' in WPT, we've historically chosen to accept tests like this as they test valid spec behavior without being browser specific. That is, any implementation which failed this test would be against spec. |
web-platform-tests/rfcs#33 is adding proper support for crash tests in WPT and then this could probably be rewritten to not use testharness.js and thus avoid the problem entirely. There are differences between |
…ness.js Previously this test would fail when loaded locally as the testharness.js cleanup code would try to access document.documentElement, which had been removed. Instead, use the crashtest support (https://web-platform-tests.org/writing-tests/crashtest.html). Fixes #20020
…ness.js Previously this test would fail when loaded locally as the testharness.js cleanup code would try to access document.documentElement, which had been removed. Instead, use the crashtest support (https://web-platform-tests.org/writing-tests/crashtest.html). Fixes #20020
…ness.js Previously this test would fail when loaded locally as the testharness.js cleanup code would try to access document.documentElement, which had been removed. Instead, use the crashtest support (https://web-platform-tests.org/writing-tests/crashtest.html). Fixes #20020
…ness.js (#21052) Previously this test would fail when loaded locally as the testharness.js cleanup code would try to access document.documentElement, which had been removed. Instead, use the crashtest support (https://web-platform-tests.org/writing-tests/crashtest.html). Fixes #20020
The test at css/css-animations/keyframes-remove-documentElement-crash.html causes a harness failure because it removes the
<body>
element:I'm not sure what the right way would be to address this given the test design. It does seem somewhat arbitrary that this test exists in the WPT suite though.
Tagging the author of the test @lilles, its reviewer @mstensho, other Blink developers working on Web Animations @stephenmcgruer @flackr and all-around knowledgeable person @birtles.
The text was updated successfully, but these errors were encountered: