py3status: add dbus-python dependency #72297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the spotify module work.
|
What's the impact on the closure size? |
jonringer
approved these changes
Oct 30, 2019
There was a problem hiding this comment.
nix-review passes on NixOS
diff LGTM
fixes import issue
[4 built, 8 copied (2.3 MiB), 0.9 MiB DL]
https://github.com/NixOS/nixpkgs/pull/72297
3 package were build:
python27Packages.py3status python37Packages.py3status python38Packages.py3status
[nix-shell:/home/jon/.cache/nix-review/pr-72297]$ nix path-info -Sh ./results/python37Packages.py3status
/nix/store/3z4cgif8z1j1hqhiq10i95sf1spd35f7-python3.7-py3status-3.21 635.2M
[08:43:50] jon@jon-desktop /home/jon/projects/nixpkgs (master)
$ nix path-info -Sh ./result
/nix/store/yknd6wq5vbls0cpyp7fmw6g71lyaaivk-python3.7-py3status-3.21 630.0M
master:
[nix-shell:/home/jon/projects/nixpkgs]$ python
Python 3.7.4 (default, Jul 8 2019, 18:31:06)
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import py3status.modules.spotify
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/nix/store/p4afrmyw7g0cz97m7dx173q78j13fj0m-python3.7-py3status-3.20/lib/python3.7/site-packages/py3status/modules/spotify.py", line 58, in <module>
import dbus
ModuleNotFoundError: No module named 'dbus'
>>>
PR:
[nix-shell:/home/jon/.cache/nix-review/pr-72297]$ nix-shell --pure -p "with import ./nixpkgs {}; python3Packages.py3status"
[nix-shell:/home/jon/.cache/nix-review/pr-72297]$ python
Python 3.7.5 (default, Oct 14 2019, 23:08:55)
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import py3status.modules.spotify
>>>
|
@GrahamcOfBorg build python27Packages.py3status python37Packages.py3status python38Packages.py3status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the spotify module work.
Because the derivation is missing the dependency, the module refuses to load. The usage import is here: https://github.com/ultrabug/py3status/blob/master/py3status/modules/spotify.py#L63
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @