Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

networkmanager: fix PPPD_PATH #72362

Merged
merged 2 commits into from Nov 5, 2019
Merged

networkmanager: fix PPPD_PATH #72362

merged 2 commits into from Nov 5, 2019

Conversation

worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Oct 31, 2019 •
edited

Motivation for this change

Fixes #72330

Upstream MR: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/merge_requests/323

Here's a monkey patch to test it off of master

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This was referenced Oct 31, 2019
Merged
Closed
@worldofpeace worldofpeace added this to Needs review in Staging Oct 31, 2019
worldofpeace added a commit to worldofpeace/nixpkgs that referenced this pull request Nov 3, 2019
@worldofpeace
networkmanager: fix PPPD_PATH
e839313 
Fixes NixOS#72330 for 19.09.

Upstream MR: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/merge_requests/323

Fix on master: NixOS#72362
@worldofpeace worldofpeace merged commit e6393df into NixOS:staging Nov 5, 2019
Staging automation moved this from Needs review to Done Nov 5, 2019
@worldofpeace worldofpeace deleted the nm-fix-pppd-path branch November 5, 2019 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@Phreedom Phreedom Awaiting requested review from Phreedom

@domenkozar domenkozar Awaiting requested review from domenkozar

@obadz obadz Awaiting requested review from obadz

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+ 11.by: package-maintainer
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worldofpeace @jtojnar