Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update elm-language-server to 1.4.4 #72359

Merged
merged 1 commit into from Oct 31, 2019
Merged

Update elm-language-server to 1.4.4 #72359

merged 1 commit into from Oct 31, 2019

Conversation

andys8
Copy link
Member

@andys8 andys8 commented Oct 31, 2019

Motivation for this change

Update elm-language-server to 1.4.4

Things done

Ran generate-node-packages.sh script.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @turboMaCk

@andys8 andys8 marked this pull request as ready for review October 31, 2019 12:14
@Mic92 Mic92 merged commit 4f1c14a into NixOS:master Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andys8 @Mic92 @Janik-Haag