Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add session feature request/usage recording #20000

Merged
merged 1 commit into from Nov 7, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Oct 30, 2019

This enables WebXR sessions to record which features they requested,
which features were granted, as well as which features were used or
attempted to be used. This also fixes a small bug where the stop time
was not being recorded for inline sessions.

Bug: 995849
Change-Id: If025e5485dd9a99cd4bf0da63860dcd4f96413f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867199
Commit-Queue: Will Cassella <cassew@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713345}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@foolip
Copy link
Member

foolip commented Oct 30, 2019

Congrats on the 20k PR, @chromium-wpt-export-bot!

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1867199 branch 6 times, most recently from b6db2b3 to 5ca2a09 Compare November 7, 2019 00:02
This enables WebXR sessions to record which features they requested,
which features were granted, as well as which features were used or
attempted to be used. This also fixes a small bug where the stop time
was not being recorded for inline sessions.

Bug: 995849
Change-Id: If025e5485dd9a99cd4bf0da63860dcd4f96413f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867199
Commit-Queue: Will Cassella <cassew@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713345}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants