Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.09] gitlab backports #72395

Merged
merged 5 commits into from Nov 2, 2019
Merged

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Oct 31, 2019

This backports recent gitlab updates to 19.09:

  • ac86816 - gitlab: 12.4.0 -> 12.4.1
  • 5f49f97 - gitlab-runner: 12.4.0 -> 12.4
  • bac832e - nixos/gitlab: Remove the old lib symlink in the state directory
  • d0d6d8f - nixos/gitlab: Abort on error and use of unset variables
  • 95d999b - gitlab: 12.3.5 -> 12.4.0
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @max-wittig

talyz and others added 5 commits November 1, 2019 00:27
- gitlab-shell no longer requires ruby for anything else than the
  install script, so the bundlerEnv stuff could be dropped

- gitlab-shell and gitlab-workhorse now report their versions
  correctly

(cherry picked from commit 5081a6c)
Default behavior is to continue executing the script even when one or
multiple steps fail. We want to abort early if any part of the
initialization fails to not run with a partially initialized state.

Default behavior also allows dereferencing non-existent variables,
potentially resulting in hard-to-find bugs.

(cherry picked from commit 041cbd8)
Also, remove the old and unused PermissionsStartOnly definition in the
gitlab-workhorse systemd service.

(cherry picked from commit d5db11c)
(cherry picked from commit f22dc52)
(cherry picked from commit 2e8417b)
@flokli flokli requested review from talyz and bgamari October 31, 2019 23:31
@flokli flokli mentioned this pull request Oct 31, 2019
10 tasks
@flokli
Copy link
Contributor Author

flokli commented Oct 31, 2019

@GrahamcOfBorg test gitlab

Copy link
Contributor

@talyz talyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested basic functionality in a VM without issues (except broken welcome screen images, but that's a GitLab bug).

@flokli flokli merged commit a1b46bd into NixOS:release-19.09 Nov 2, 2019
@flokli flokli deleted the 19.09-gitlab-12.4.1 branch November 2, 2019 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants