Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jack2: 1.9.12 -> 1.9.13, addressing CVE-2019-13351 #72397

Merged
merged 1 commit into from
Nov 3, 2019
Merged

jack2: 1.9.12 -> 1.9.13, addressing CVE-2019-13351 #72397

merged 1 commit into from
Nov 3, 2019
+2 −7

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Oct 31, 2019

Motivation for this change

https://nvd.nist.gov/vuln/detail/CVE-2019-13351

Aimed at staging because there are too many reverse dependencies for me to build myself. Would be good if someone could trigger a darwin build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@risicle
jack2: 1.9.12 -> 1.9.13 (security)
d14974f 
addressing CVE-2019-13351

removing now-redundant patch fixing build on macos
@ofborg ofborg bot requested a review from cillianderoiste November 1, 2019 00:20
@veprbl veprbl added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Nov 1, 2019
@FRidh
Copy link
Member

FRidh commented Nov 2, 2019

there seems to be an issue fetching the source

@risicle
Copy link
Contributor Author

risicle commented Nov 2, 2019

That's weird.

@GrahamcOfBorg build jack2

@FRidh FRidh merged commit e3e9af4 into NixOS:staging Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cillianderoiste cillianderoiste

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
Staging
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@risicle @FRidh @veprbl