Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromium: do not load .so files from current working directory #72343

Merged
merged 1 commit into from Nov 1, 2019
Merged

chromium: do not load .so files from current working directory #72343

merged 1 commit into from Nov 1, 2019

Conversation

ivan
Copy link
Member

@ivan ivan commented Oct 31, 2019

Motivation for this change

This fixes #67234.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I tested three combinations with a bad .so file in cwd:

  • {no libPath}
  • {present LD_LIBRARY_PATH, present libPath}
  • {no LD_LIBRARY_PATH, present libPath}
Notify maintainers

cc @bendlas

@ivan ivan mentioned this pull request Oct 31, 2019
Merged
10 tasks
@ofborg ofborg bot requested a review from bendlas October 31, 2019 01:51
MasseR
MasseR approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@MasseR MasseR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might have had the comments on the nix side instead of the shell, but looks good to me.

@grahamc grahamc merged commit 30b1064 into NixOS:master Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MasseR MasseR MasseR approved these changes

@bendlas bendlas Awaiting requested review from bendlas

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem starting chromium
3 participants
@ivan @MasseR @grahamc