New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloud-custodian: init at 0.8.45.1 #72325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you're going to remain an application outside of python-modules, then you should pass in the python interpreter to the expression and use python.pkgs
to access the packages
5e7f9aa
to
459f430
Compare
Thanks @jonringer; updated accordingly. Looks nicer, and the package even has the same hash after refactoring to validate! @GrahamcOfBorg build cloud-custodian |
@FRidh just want to make sure this is a best practice, as it looks good to me :) |
@jonringer @FRidh any updates on this one? Happy to make further changes if necessary. |
Co-Authored-By: Jon <jonringer@users.noreply.github.com>
43887a9
to
5917f58
Compare
@GrahamcOfBorg build cloud-custodian |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nix-review
passes on NixOS
diff LGTM
executable shows usage
[3 built, 14 copied (39.9 MiB), 3.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/72325
1 package were build:
cloud-custodian
Motivation for this change
Tool for managing cloud cluster security/cost/etc.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @