Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

svaba: init at 1.1.0 #72326

Merged
merged 1 commit into from
Dec 8, 2019
Merged

svaba: init at 1.1.0 #72326

merged 1 commit into from
Dec 8, 2019
+44 −0

Conversation

scalavision
Copy link
Contributor

Motivation for this change
Things done
  • [ x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [x ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • [x ] Tested execution of all binary files (usually in ./result/bin/)
  • [ x] Determined the impact on package closure size (by running nix path-info -S before and after)
  • [ x] Ensured that relevant documentation is up to date
  • [ x] Fits CONTRIBUTING.md.
Notify maintainers

cc @ vyp

Sorry, something went wrong.

@scalavision
Copy link
Contributor Author

scalavision commented Oct 30, 2019 •
edited
Loading

Thanks for your feedback @vyp !!

I made a mistake while squashing, so had to recreate the PR. Hope everything is fine now :-)

You commented that I had forgotten to reuse pname in repo attribute, and version in rev attribute under src.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 30, 2019
jonringer
jonringer reviewed Oct 31, 2019
View reviewed changes
pkgs/applications/science/biology/svaba/default.nix Outdated

src = fetchFromGitHub {
owner = "walaj";
repo = "${pname}";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
repo = "${pname}";
repo = "pname;

pkgs/applications/science/biology/svaba/default.nix Outdated
src = fetchFromGitHub {
owner = "walaj";
repo = "${pname}";
rev = "${version}";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rev = "${version}";
rev = version;

pkgs/applications/science/biology/svaba/default.nix Outdated
Comment on lines 24 to 28
description = "Structural variant and INDEL caller for DNA sequencing data, using genome-wide local assembly";
license = licenses.gpl3;
maintainers = with maintainers; [ scalavision ];
platforms = platforms.linux;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the github repo as a home page, please

vyp
vyp suggested changes Oct 31, 2019
View reviewed changes
pkgs/applications/science/biology/svaba/default.nix Outdated
installPhase = ''
runHook preInstall
install -Dm555 src/svaba/svaba $out/bin/svaba
runHook postInstal
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
runHook postInstal
runHook postInstall

@scalavision
Copy link
Contributor Author

sorry for my silly mistakes! I've think I've fixed everything now @jonringer , @vyp

Thanks again for helping out :-)

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/explicit-runhook-in-derivation/4614/10

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/explicit-runhook-in-derivation/4614/14

@scalavision
Copy link
Contributor Author

Regarding the discussions on nixos-discourse. I've added those hooks based upon feedback on this PR. I have not enough insight into nix package internals, so I'll do whatever is suggested.

Lassulus
Lassulus approved these changes Dec 8, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review

@Lassulus Lassulus merged commit 3dfabd6 into NixOS:master Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer

@vyp vyp

@Lassulus Lassulus

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@scalavision @nixos-discourse @Lassulus @vyp @jonringer