Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

itstool: Don't use Python 3 yet #72335

Closed
wants to merge 1 commit into from
Closed

itstool: Don't use Python 3 yet #72335

wants to merge 1 commit into from

Conversation

chkno
Copy link
Member

@chkno chkno commented Oct 30, 2019

Motivation for this change

Fix NixOS tests on staging, which broke after #63174 was merged.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @FRidh

@chkno
itstool: Don't use Python 3 (yet)
8b3885f 
Per http://itstool.org/download.html , itstool doesn't support python3
until version 2.0.3 (and perhaps doesn't support it correctly until
2.0.5).

This change allows NixOS tests to run again after NixOS#63174 broke
shared-mime-info.
@chkno chkno mentioned this pull request Oct 30, 2019
Merged
10 tasks
@worldofpeace
Copy link
Contributor

@chkno See #63174 (comment), I believe there's some way we could use python3 for itstool as other distros have already achieved this.

@chkno chkno mentioned this pull request Oct 31, 2019
Merged
10 tasks
@chkno
Copy link
Member Author

chkno commented Oct 31, 2019

If this goes forward, #72342 (itstool 2.0.2 -> 2.0.6) should not. I don't know which all-around best. My interest here is just to be able to run NixOS tests on staging.

@FRidh FRidh self-assigned this Oct 31, 2019
@worldofpeace
Copy link
Contributor

@chkno The best choice is to be able to use python3 because that is what we're going for in 20.03.
I think going forward if we're going to try to switch things to python3 it's pretty easy to check on other distros to learn if they're carrying any patches and even read their threads. Because it's basically duplicated work, and most issues won't be nix specific.

@jtojnar
Copy link
Contributor

jtojnar commented Nov 1, 2019

Closing as #72342 was merged.

@jtojnar jtojnar closed this Nov 1, 2019
@chkno chkno deleted the itstool-python-2 branch November 4, 2019 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@FRidh FRidh

Labels
1.severity: blocker 10.rebuild-darwin: 11-100 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chkno @worldofpeace @jtojnar @FRidh