Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firestarter: 1.7.3 -> 1.7.4 #72334

Merged
merged 1 commit into from Oct 31, 2019
Merged

firestarter: 1.7.3 -> 1.7.4 #72334

merged 1 commit into from Oct 31, 2019

Conversation

astro
Copy link
Contributor

@astro astro commented Oct 30, 2019

Motivation for this change

New version update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

I am maintainer of this package in nixpkgs.

@FRidh
Copy link
Member

FRidh commented Oct 31, 2019

@GrahamcOfBorg build firestarter

c0bw3b
c0bw3b approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review pr 72334 1

1 package were build:
  • firestarter
$ ./results/firestarter/bin/firestarter --version
FIRESTARTER - A Processor Stress Test Utility, Version 1.7 4 (github), build: 2019-10-31
Copyright (C) 2019 TU Dresden, Center for Information Services and High Performance Computing

@c0bw3b c0bw3b merged commit 46911eb into NixOS:master Oct 31, 2019
@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 31, 2019

@astro in a future update, you may add runHook preInstall and runHook postInstall to you installPhase override

@veprbl veprbl mentioned this pull request Jul 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@astro @FRidh @c0bw3b