Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stress-ng: 0.10.05 -> 0.10.08 #72333

Merged
merged 1 commit into from Oct 31, 2019
Merged

stress-ng: 0.10.05 -> 0.10.08 #72333

merged 1 commit into from Oct 31, 2019

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Oct 30, 2019

Motivation for this change

Version update
+ fixes #72292

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

jonringer
jonringer approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
commits LGTM
executable seems to work

[3 built, 1 copied (0.4 MiB), 0.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/72333
1 package were build:
stress-ng

@jonringer
Copy link
Contributor

@GrahamcOfBorg build stress-ng

@c0bw3b c0bw3b merged commit cbc94a0 into NixOS:master Oct 31, 2019
@c0bw3b c0bw3b deleted the pkg/stress-ng branch October 31, 2019 07:58
@c0bw3b
Copy link
Contributor Author

c0bw3b commented Oct 31, 2019

BTW I meant to ping @matthewbauer just FYI.
The darwin patch you upstreamed to libbsd may break builds on non-Darwin platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stress-ng: fails to build on missing strlcat
2 participants
@c0bw3b @jonringer