Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sapmachine: init at 13.0.1 #72385

Closed
wants to merge 13 commits into from
Closed

sapmachine: init at 13.0.1 #72385

wants to merge 13 commits into from
+105 −0

Conversation

choas
Copy link

@choas choas commented Oct 31, 2019

Motivation for this change

Homepage: https://sapmachine.io

This project contains a downstream version of the OpenJDK project. It is used to build and maintain a SAP supported version of OpenJDK for SAP customers and partners who wish to use OpenJDK to run their applications.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

Sorry, something went wrong.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Nov 2, 2019
@choas
Update default.nix
62aa45c 
remove commented out code (version 11)
choas and others added 5 commits November 18, 2019 23:31
@choas @Lassulus
Update pkgs/development/compilers/sapmachine/default.nix
15ee5ba 
Co-Authored-By: Lassulus <github@lassul.us>
@choas @Lassulus
Update pkgs/development/compilers/sapmachine/default.nix
fd1cca4 
Co-Authored-By: Lassulus <github@lassul.us>
@choas @Lassulus
Update pkgs/development/compilers/sapmachine/default.nix
8b2564b 
Co-Authored-By: Lassulus <github@lassul.us>
@choas
Update 11.nix
457a5f5 
based on suggestions by Lassulus for default.nix file
@choas
remove passthru with jdk
dade0b3
choas and others added 4 commits November 19, 2019 22:12
@choas @Lassulus
Update pkgs/development/compilers/sapmachine/default.nix
8d8d41f 
change name to pname (by Lassulus)

Co-Authored-By: Lassulus <github@lassul.us>
@choas @Lassulus
Update pkgs/development/compilers/sapmachine/11.nix
b14744d 
change name to pname (by Lassulus)

Co-Authored-By: Lassulus <github@lassul.us>
@choas
move attributes inside derivation (by Lassulus)
7c6c457
@choas
Merge branch 'master' of https://github.com/choas/nixpkgs
e54b1e1
@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
ryantm
ryantm requested changes Sep 24, 2020
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please clean up the git history to match the CONTRIBUTING submitting changes section?

If you are adding yourself to the maintainer list

Typically, have two commits:

  • Commit 1: The changes without adding a maintainer.
  • Commit 2: Adds you to the maintainers list and adds you as maintainer of the package

Otherwise

Typically, have one commit.

pkgs/development/compilers/sapmachine/11.nix
'';

meta = with stdenv.lib; {
homepage = https://sap.github.io/SapMachine/;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please quote URLs per RFC 45.

pkgs/development/compilers/sapmachine/11.nix

meta = with stdenv.lib; {
homepage = https://sap.github.io/SapMachine/;
license = licenses.gpl2;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gpl license variants without the Plus or Only suffix are deprecated, because they do not specify the license well enough. Use Plus if the project has "or later" sections in the actual source code files (not the license). Otherwise, use the Only suffix.

pkgs/development/compilers/sapmachine/default.nix

meta = with stdenv.lib; {
homepage = https://sap.github.io/SapMachine/;
license = licenses.gpl2;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gpl license variants without the Plus or Only suffix are deprecated, because they do not specify the license well enough. Use Plus if the project has "or later" sections in the actual source code files (not the license). Otherwise, use the Only suffix.

pkgs/development/compilers/sapmachine/default.nix
'';

meta = with stdenv.lib; {
homepage = https://sap.github.io/SapMachine/;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please quote URLs per RFC 45.

@ryantm
Copy link
Member

ryantm commented Sep 24, 2020

I was able to build this successfully build sapmachine on NixOS, but when I tried to run javac I noticed it has an interpreter set to /lib64/ld-linux-x86-64.so.2 so something needs to be fixed with the interpreter:

$ file ./result/bin/javac
./result/bin/javac: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, for GNU/Linux 2.6.4, not stripped

@SuperSandro2000
Copy link
Member

Closing due to inactivity. Please reopen the discussion if this is still important to you.

@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus

@ryantm ryantm

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@choas @ryantm @SuperSandro2000 @Lassulus @Janik-Haag