Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox, firefox-bin: 70.0 -> 70.0.1 #72364

Merged
merged 2 commits into from Nov 2, 2019
Merged

firefox, firefox-bin: 70.0 -> 70.0.1 #72364

merged 2 commits into from Nov 2, 2019

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Oct 31, 2019

Motivation for this change

Release notes are not updated yet.

https://www.mozilla.org/en-US/firefox/70.0.1/releasenotes/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Tested only firefox-bin.

Notify maintainers

cc @edolstra @andir

@taku0 taku0 changed the title firefox, firefox-bin: 69.0.2 -> 70.0.1 firefox, firefox-bin: 70.0 -> 70.0.1 Oct 31, 2019
@ofborg ofborg bot requested review from edolstra and andir October 31, 2019 12:43
@andir andir self-assigned this Nov 1, 2019
vcunat
vcunat approved these changes Nov 2, 2019
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both seem to work fine.

vcunat added a commit that referenced this pull request Nov 2, 2019
@vcunat
Merge #72364: firefox*: 70.0 -> 70.0.1
a2e12f9
@vcunat vcunat merged commit 0bc5d7f into NixOS:master Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@edolstra edolstra Awaiting requested review from edolstra

@andir andir Awaiting requested review from andir

Assignees

@andir andir

Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@taku0 @vcunat @andir