Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jhead: add patches for CVE-2019-1010301, CVE-2019-1010302 #72387

Merged
merged 1 commit into from
Oct 31, 2019
Merged

jhead: add patches for CVE-2019-1010301, CVE-2019-1010302 #72387

merged 1 commit into from
Oct 31, 2019
+14 −1

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Oct 31, 2019

Motivation for this change

https://nvd.nist.gov/vuln/detail/CVE-2019-1010301
https://nvd.nist.gov/vuln/detail/CVE-2019-1010302

Most of the discussion/fixing of this issue has happened here https://bugzilla.redhat.com/show_bug.cgi?id=1679952 with little help from upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@ofborg ofborg bot requested a review from rycee October 31, 2019 21:42
@mmahut mmahut added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Oct 31, 2019
@mmahut
Copy link
Member

mmahut commented Oct 31, 2019

@GrahamcOfBorg build jhead

@mmahut mmahut added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 31, 2019
@mmahut
Copy link
Member

mmahut commented Oct 31, 2019

Thank you @risicle, feel free to open against the release branch and assign it to me.

@mmahut mmahut merged commit fb5130d into NixOS:master Oct 31, 2019
@risicle risicle mentioned this pull request Oct 31, 2019
Merged
10 tasks
@risicle risicle mentioned this pull request Nov 9, 2019
Merged
10 tasks
@TredwellGit TredwellGit added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rycee rycee

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@risicle @mmahut @TredwellGit