add package for pkgdiff #72312
Merged
add package for pkgdiff #72312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
reviewed
Oct 31, 2019
jonringer
reviewed
Oct 31, 2019
Mic92
reviewed
Oct 31, 2019
c0bw3b
reviewed
Oct 31, 2019
c0bw3b
approved these changes
Nov 1, 2019
There was a problem hiding this comment.
Result of nix-review pr 72312 1
1 package were build:
- pkgdiff
$ ./results/pkgdiff/bin/pkgdiff --version
Package Changes Analyzer (PkgDiff) 1.7.2
Copyright (C) 2016 Andrey Ponomarenko's ABI Laboratory
License: GNU GPL <http://www.gnu.org/licenses/>
This program is free software: you can redistribute it and/or modify it.
Written by Andrey Ponomarenko.
jonringer
approved these changes
Nov 1, 2019
There was a problem hiding this comment.
nix-review passes on NixOS
diff LGTM
executable seems to work
[3 built, 1 copied (0.5 MiB), 0.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/72312
1 package were build:
pkgdiff
[nix-shell:~/.cache/nix-review/pr-72312]$ nix path-info -Sh ./results/pkgdiff
/nix/store/rj3zpplhxl7y5bi4girp3z0ykggjyh3a-pkgdiff-1.7.2 81.5M
|
@GrahamcOfBorg build pkgdiff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
pkgdiff package is missing
Things done
implement pkgdiff package
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)