Ansible: Fix connection plugins and add support for NETCONF #72370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mweinelt
force-pushed
the
pr/ansible/netconf
branch
2 times, most recently
from
8058cfc
to
8dadc40
Compare
|
Also https://github.com/NixOS/nixpkgs/pull/72370/files#diff-7fba719869598b74dcfbab4a83d750a5R32 looks like a no-op to me. No |
FRidh
reviewed
Oct 31, 2019
Ansible tries to execute the ansible-connection script as a python script from within it's task executor. This does not work when it is encapsulated in a shell script. Therefore remove the call to the python interpreter and use the wrapped version directly. Fixes NixOS#71342
mweinelt
force-pushed
the
pr/ansible/netconf
branch
from
8dadc40
to
2556878
Compare
- boto was dropped from propagatedBuildInputs in 4af94d0f - lib/ansible/constants.py does not have "/usr" anywhere in v2.4..v2.9
mweinelt
force-pushed
the
pr/ansible/netconf
branch
from
228f025
to
d61c571
Compare
mweinelt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
Patches Ansible to use the unwrapped version of
ansible-connection, as it executes it through a python interpreter, which currently results in a SyntaxError. Fixes Ansible: Task runs into syntax error when using ansible_connection=netconf #71342Includes
ncclientto add support for netconf connections to configure network hardware.sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)/nix/store/8hz5c81n1cfgwczn267y1prdizhw55q8-python3.7-ansible-2.8.4 220.9M/nix/store/azxh8l7bvkga12yk10zm0qscc5ai6cah-python3.7-ansible-2.8.4 228.4MNotify maintainers
cc @joamaki @costrouc