Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustPlatform.buildRustPackage: Add support for setting test flags #75061

Closed
wants to merge 1 commit into from
Closed

rustPlatform.buildRustPackage: Add support for setting test flags #75061

wants to merge 1 commit into from

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Dec 5, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@bkchr
Copy link
Contributor Author

bkchr commented Dec 10, 2019

CC @andir as I have seen you have other similar stuff before.

@andir
Copy link
Member

andir commented Dec 12, 2019

@GrahamcOfBorg build cargo-graph cargo-xbuild cargo-expand alacritty

andir
andir reviewed Dec 12, 2019
View reviewed changes
Copy link
Member

@andir andir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine generally but I'd just like to cleanup that little bit of duplicate code I commented on.

pkgs/build-support/rust/default.nix Outdated
@@ -144,10 +145,10 @@ stdenv.mkDerivation (args // {
runHook postBuild
'';

checkPhase = args.checkPhase or ''
checkPhase = with builtins; args.checkPhase or ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we prefer using lib here. In general having a let-binding like let flags = lib.concatStringsSep " " cargoTestFlags; in would remove the need for the with (only need it once anyway) and make the code less repetitive.

@andir andir self-assigned this Dec 12, 2019
@bkchr
Copy link
Contributor Author

bkchr commented Dec 20, 2019

@andir is it now better?

@bkchr
Copy link
Contributor Author

bkchr commented Jan 9, 2020

Ping @andir

@andir
Copy link
Member

andir commented Jan 9, 2020

Sorry for the delay. I largely gave up on buildRustPackage myself. I think this looks better now. What we should add is documentation to doc/languages-frameworks/rust.section.md and preferable some kind of test for this seldomly used feature. We do not want it to bitrot :)

@bkchr bkchr closed this Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir andir left review comments

Assignees

@andir andir

Labels
6.topic: rust 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bkchr @andir