Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/programs/shell.nix: retain defexpr symlink #75060

Closed
wants to merge 1 commit into from
Closed

nixos/programs/shell.nix: retain defexpr symlink #75060

wants to merge 1 commit into from

Conversation

ryan4729
Copy link
Contributor

@ryan4729 ryan4729 commented Dec 5, 2019

Motivation for this change

Previously the script would delete and recreate ~/.nix-defexpr when it was a symlink

This is a PR against the 19.09 branch since the script was removed in master at 4e0d6a5

I would be interested to know how ~/.nix-defexpr is managed in master as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

nixos/programs/shell.nix: retain defexpr symlink
e70b3d1 
Previously the script would delete and recreate .nix-defexpr when it was a symlink
@worldofpeace worldofpeace changed the base branch from nixos-19.09 to release-19.09 December 6, 2019 02:50
@ryan4729
Copy link
Contributor Author

ryan4729 commented Jan 4, 2020

This was fixed in release-19.09 by 487288f

@ryan4729 ryan4729 closed this Jan 4, 2020
@ryan4729 ryan4729 deleted the defexprs-symlink branch January 4, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ryan4729