Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gopher: 3.0.11 -> 3.0.17 #75090

Merged
merged 1 commit into from Dec 8, 2019
Merged

gopher: 3.0.11 -> 3.0.17 #75090

merged 1 commit into from Dec 8, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 6, 2019 •
edited

Motivation for this change

noticed it was out of date in @r-ryantm logs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/75090
1 package were built:
gopher

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build gopher

@ofborg ofborg bot requested a review from sternenseemann December 6, 2019 09:32
sternenseemann
sternenseemann approved these changes Dec 6, 2019
View reviewed changes
Copy link
Member

@sternenseemann sternenseemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and works fine, package implementation cleaner 👍

Ma27
Ma27 approved these changes Dec 6, 2019
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested locally. Before merging, it would be cool if you could either look into th edarwin build issue or exclude the platform :)

@jonringer
Copy link
Contributor Author

I did, the issue is that they have a local file called regex.h which is colliding with the std regex.h

@jonringer
Copy link
Contributor Author

for some reason, gcc will resolve it correct, but clang crashes and burns (which is appropriate)

@Ma27
Copy link
Member

Ma27 commented Dec 6, 2019

Is there an upstream bugreport? (or probably even a patch?) :)

@jonringer
Copy link
Contributor Author

don't think so, I don't think there's been any real activity in 2 years on gopher. Also the previous gopher.x86_64-darwin build was failing https://hydra.nixos.org/eval/1558523?filter=gopher&compare=1558502&full=

I think I'm just going to mark this as linux only

@jonringer
Copy link
Contributor Author

other option is to do stdenv = gccStdenv

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build gopher

@ofborg ofborg bot requested a review from sternenseemann December 7, 2019 05:26
@jonringer jonringer merged commit bd6c0ce into NixOS:master Dec 8, 2019
@jonringer jonringer deleted the bump-gopher branch December 8, 2019 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sternenseemann sternenseemann sternenseemann approved these changes

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @Ma27 @sternenseemann