Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gnome extension workspace-grid is now workspace-matrix #75123

Merged
merged 2 commits into from Dec 17, 2019
Merged

Gnome extension workspace-grid is now workspace-matrix #75123

merged 2 commits into from Dec 17, 2019

Conversation

chkno
Copy link
Member

@chkno chkno commented Dec 6, 2019

Motivation for this change

Add workspace-matrix Gnome extension. Also, remove crufty, unused workspace-grid that it replaces.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @aneeshusa

@chkno chkno force-pushed the workspace-grid-is-now-workspace-matrix branch from dba72f3 to 5597400 Compare December 7, 2019 00:32
@chkno chkno mentioned this pull request Dec 7, 2019
Closed
10 tasks
@chkno
Copy link
Member Author

chkno commented Dec 7, 2019

Oh, oops, there's another already-open PR for this: #67876. But it's stale (unresponsive for 3 months), so I guess it makes sense to continue here?

@worldofpeace
Copy link
Contributor

Oh, oops, there's another already-open PR for this: #67876. But it's stale (unresponsive for 3 months), so I guess it makes sense to continue here?

That's fine by me.

@chkno
gnomeExtensions.workspace-matrix: Init at 3.0.0
1e97dbb
@chkno
gnomeExtensions.workspace-grid: Remove
492de5c 
workspace-matrix largely replaces workspace-grid [1].

Also, workspace-grid.nix was accidentally dropped from
top-level/all-packages.nix in the Gnome 3.18 -> 3.20 bump in
5a245c2, so this file has been
unreferenced for three years.

[1] zakkak/workspace-grid#120 (comment)
@chkno chkno force-pushed the workspace-grid-is-now-workspace-matrix branch from 5597400 to 492de5c Compare December 8, 2019 21:54
worldofpeace
worldofpeace approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. works.

@worldofpeace worldofpeace merged commit 77d0815 into NixOS:master Dec 17, 2019
@worldofpeace
Copy link
Contributor

Huh, I don't think workspace-grid.nix was even called anywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chkno @worldofpeace @jtojnar