Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] thunderbird, thunderbird-bin: 68.2.2 -> 68.3.0 #75126

Closed
wants to merge 2 commits into from
Closed

[19.09] thunderbird, thunderbird-bin: 68.2.2 -> 68.3.0 #75126

wants to merge 2 commits into from

Conversation

das-g
Copy link
Member

@das-g das-g commented Dec 7, 2019

Motivation for this change

Backport of #74973

Thunderbird 68.3 comes with fixes for several security vulnerabilities, some of them with "high" impact according to Mozilla.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/):
    • /nix/store/y48mj45c834k64hih929p629gfr2840h-thunderbird-68.3.0/bin/thunderbird
    • /nix/store/nslx1b6by3gmplp4gx0hlk2y0g6hdzzm-thunderbird-bin-68.3.0/bin/thunderbird
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @nbp, @edolstra

@taku0 @das-g
thunderbird-bin: 68.2.2 -> 68.3.0
6cb95bc 
(cherry picked from commit f5dcff1)
@ofborg ofborg bot requested review from edolstra and nbp December 7, 2019 00:28
@nh2
Copy link
Contributor

nh2 commented Dec 7, 2019

@GrahamcOfBorg build

nh2
nh2 approved these changes Dec 7, 2019
View reviewed changes
Copy link
Contributor

@nh2 nh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review pr --checkout commit 75126 succeeded on this.

GUI starts.

@taku0 @das-g
thunderbird: 68.2.2 -> 68.3.0
d059942 
(cherry picked from commit 85e99ba)
@das-g
Copy link
Member Author

das-g commented Dec 7, 2019

Removed patch like in #74973 (comment). (See #74973 (comment))

@das-g das-g mentioned this pull request Dec 9, 2019
Closed
10 tasks
@das-g
Copy link
Member Author

das-g commented Feb 28, 2020

obsoleted by 943560f & 71b278c, closing

@das-g das-g closed this Feb 28, 2020
@das-g das-g deleted the thunderbird-68.3.0 branch February 28, 2020 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nh2 nh2 nh2 approved these changes

@edolstra edolstra Awaiting requested review from edolstra

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@das-g @nh2 @taku0