Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clojure-lsp: init at release-20191223T204324 #75124

Merged
merged 1 commit into from Dec 26, 2019
Merged

clojure-lsp: init at release-20191223T204324 #75124

merged 1 commit into from Dec 26, 2019

Conversation

ericdallo
Copy link
Member

Motivation for this change

Add clojure-lsp derivation

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-december/1711/12

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/95

@ericdallo ericdallo changed the title clojure-lsp: init at release-20191202T142318 clojure-lsp: init at release-20191223T204324 Dec 25, 2019
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/98

@marsam
Copy link
Contributor

marsam commented Dec 26, 2019

Thank you for your contribution. I made minor changes, I hope you don't mind.
Please feel free to ping me if any PR gets stuck

@marsam
Copy link
Contributor

marsam commented Dec 26, 2019

btw, currently clojure-lsp is self-contained Java program, and relies in the Java runtime present in the user environment, maybe later we could add a wrapper with jre

@marsam marsam merged commit dce6d41 into NixOS:master Dec 26, 2019
@ericdallo
Copy link
Member Author

Thank you very much @marsam, I totally agree with these future changes!

@ericdallo ericdallo deleted the add-clojure-lsp branch December 26, 2019 12:33
@ericdallo ericdallo mentioned this pull request Dec 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ericdallo @nixos-discourse @marsam