Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge pull request #75172 from ivan/libimobiledevice-bump #75172

Merged
merged 2 commits into from Jan 15, 2020
Merged

Merge pull request #75172 from ivan/libimobiledevice-bump #75172

merged 2 commits into from Jan 15, 2020

Conversation

ivan
Copy link
Member

@ivan ivan commented Dec 7, 2019

Motivation for this change

The current version of libimobiledevice in nixpkgs always hangs before it is able to finish a idevicebackup2 backup --full DIR from my iPad mini 4 / iOS 13.2.3 device. Bumping usbmuxd and libimobiledevice fixed it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @infinisil

@ofborg ofborg bot requested a review from infinisil December 7, 2019 21:06
@arcnmx
Copy link
Member

arcnmx commented Jan 15, 2020

I had been been experiencing the same issues with idevicebackup2 and this PR did indeed fix it!

@infinisil infinisil changed the title libimobiledevice: 2019-04-04 -> 2019-11-29, usbmuxd: 2019-03-05 -> 2019-11-11 Merge pull request #75172 from ivan/libimobiledevice-bump Jan 15, 2020
@infinisil infinisil merged commit fbbe3f9 into NixOS:master Jan 15, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 15, 2020
@infinisil @dtzWill
Merge pull request NixOS#75172 from ivan/libimobiledevice-bump
8079ae4 
libimobiledevice: 2019-04-04 -> 2019-11-29, usbmuxd: 2019-03-05 -> 2019-11-11
(cherry picked from commit fbbe3f9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ivan @arcnmx @infinisil