Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

legit: init at 1.2.0 #75129

Merged
merged 1 commit into from Mar 31, 2020
Merged

legit: init at 1.2.0 #75129

merged 1 commit into from Mar 31, 2020

Conversation

ryneeverett
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

'';

meta = with lib; {
homepage = https://github.com/frostming/legit;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
homepage = https://github.com/frostming/legit;
homepage = "https://github.com/frostming/legit";

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a good reason to start quoting urls? This doesn't seem typical.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

six
];

# Unpin dependency versions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this wouldn't cause breakage? Usually there's a reason upstream pins versions, if you have tested and you think there shouldn't be a reason to pin versions, talk with upstream about it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When i submitted this PR, legit was improperly dumping requirements.txt > install_requires. Removing arbitrary dependency constraints to avoid packaging arbitrary dependency versions seems to be how this is usually handled in nixpkgs. However, this has been corrected in a subsequent release so this can indeed be removed.

@ryneeverett ryneeverett changed the title legit: init at 1.1.0 legit: init at 1.2.0 Feb 23, 2020
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@timokau timokau merged commit 24ead69 into NixOS:master Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants