New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
legit: init at 1.2.0 #75129
legit: init at 1.2.0 #75129
Conversation
bb8d417
to
e336321
Compare
''; | ||
|
||
meta = with lib; { | ||
homepage = https://github.com/frostming/legit; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
homepage = https://github.com/frostming/legit; | |
homepage = "https://github.com/frostming/legit"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a good reason to start quoting urls? This doesn't seem typical.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, NixOS/rfcs#45
six | ||
]; | ||
|
||
# Unpin dependency versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure this wouldn't cause breakage? Usually there's a reason upstream pins versions, if you have tested and you think there shouldn't be a reason to pin versions, talk with upstream about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When i submitted this PR, legit was improperly dumping requirements.txt > install_requires. Removing arbitrary dependency constraints to avoid packaging arbitrary dependency versions seems to be how this is usually handled in nixpkgs. However, this has been corrected in a subsequent release so this can indeed be removed.
e336321
to
38a4223
Compare
38a4223
to
4d9d748
Compare
4d9d748
to
e964450
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @